In short, it depends on your personal preferences and usage patterns. However, there are several factors to consider when deciding whether to turn off mobile data when on Wi-Fi.

Firstly, turning off mobile data when on Wi-Fi can help you save on your data plan. When you connect to Wi-Fi, your device uses the internet connection provided by the Wi-Fi network instead of your mobile data plan. This means that you can avoid using up your data allowance and potentially incurring additional charges from your mobile carrier.
Additionally, turning off mobile data when on Wi-Fi can help you conserve battery life. When your device is connected to both Wi-Fi and mobile data, it will automatically switch between the two depending on which connection is stronger. This can use up more battery power as your device constantly searches for the strongest signal. By turning off mobile data when on Wi-Fi, you can ensure that your device is only using the Wi-Fi connection, which can help you save battery life.
Another benefit of turning off mobile data when on Wi-Fi is that it can help you maintain a more stable internet connection. When your device is connected to both Wi-Fi and mobile data, it may switch between the two connections based on which one is stronger at that particular moment. This can cause interruptions or delays in your internet connection, which can be frustrating. By turning off mobile data when on Wi-Fi, you can ensure that your device is only using the Wi-Fi connection, which can provide a more stable and consistent internet connection.
However, there are also some potential drawbacks to turning off mobile data when on Wi-Fi. For example, if the Wi-Fi network you are connected to is slow or unreliable, turning off mobile data may mean that you have no internet access at all. In this case, it may be better to keep mobile data on as a backup.
Similarly, if you frequently move between different Wi-Fi networks (e.g., home, office, coffee shop), turning off mobile data when on Wi-Fi may not be practical. This is because your device may take some time to connect to a new Wi-Fi network, during which time you may not have internet access at all. In this case, keeping mobile data on can help ensure that you always have internet access, even if you are not currently connected to a Wi-Fi network.
Another factor to consider is your data usage habits. If you frequently use data-intensive apps or stream video content, you may still use up your data allowance even when connected to Wi-Fi. In this case, turning off mobile data when on Wi-Fi may not make much of a difference in terms of data usage. Similarly, if you have an unlimited data plan, there may be no need to turn off mobile data when on Wi-Fi, as you will not incur any additional charges for using mobile data.
In conclusion, whether or not to turn off mobile data when on Wi-Fi depends on your personal preferences and usage patterns. Turning off mobile data can help you save on your data plan, conserve battery life, and maintain a more stable internet connection. However, it may not be practical in all situations, such as when you frequently switch between different Wi-Fi networks or use data-intensive apps. Ultimately, the decision of whether or not to turn off mobile data when on Wi-Fi is up to you, and you should consider your individual needs and habits before making a decision.